gdk: Don't set backgrounds on input-only windows
authorBenjamin Otte <otte@redhat.com>
Wed, 8 Jun 2011 13:46:50 +0000 (15:46 +0200)
committerBenjamin Otte <otte@redhat.com>
Thu, 9 Jun 2011 03:51:53 +0000 (05:51 +0200)
It doesn't make sense to allow a background on input-only windows, so
instead of setting it and then never using it, we just don't ever set
it.

gdk/gdkwindow.c

index 0be4656b85e8dfbcf6a5a939968fb3615d661652..210e517ac2f1e749288c61437513ed0d372e578e 100644 (file)
@@ -6534,14 +6534,16 @@ gdk_window_set_background_pattern (GdkWindow *window,
 {
   g_return_if_fail (GDK_IS_WINDOW (window));
 
+  if (window->input_only)
+    return;
+
   if (pattern)
     cairo_pattern_reference (pattern);
   if (window->background)
     cairo_pattern_destroy (window->background);
   window->background = pattern;
 
-  if (gdk_window_has_impl (window) &&
-      !window->input_only)
+  if (gdk_window_has_impl (window))
     {
       GdkWindowImplClass *impl_class = GDK_WINDOW_IMPL_GET_CLASS (window->impl);
       impl_class->set_background (window, pattern);